Update from Sirupsen -> sirupsen #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug
nebril
reviewed
Sep 22, 2017
common/logging.go
Outdated
| @@ -242,24 +241,24 @@ func setupFluentD(logOpts map[string]string, debug bool) { | |||
| // setupLogstash sets up and configures Logstash with the provided options in | |||
| // logOpts. If some options are not provided, sensible defaults are used. | |||
| /// TODO fix me later - needs to be tested with a working logstash setup. | |||
There was a problem hiding this comment.
Can we remove it and grab it from git later/track it in a separate issue?
There was a problem hiding this comment.
What I've started doing is to file a GH issues and refer to it from the comment in the code ie in the form:
// GH-1231: text
Also update all other dependencies that were using Sirupsen instead of sirupsen Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
update-to-sirupsen-log
branch
from
ec10001 to
7053218
Compare
tgraf
reviewed
Sep 22, 2017
| @@ -25,6 +25,10 @@ Documentation | |||
| ------------- | |||
| * Add here | |||
|
|
|||
| Other | |||
| ----- | |||
| * Update Sirupsen/logrus to sirupsen/logrus (1573_) | |||
tgraf
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.