feat: adding locale to word module #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cxx into feature/word-locale
add Feature/word locale
cieslarmichal
requested changes
Oct 1, 2024
…using default en_US.
Feature/word locale
cieslarmichal
requested changes
Oct 2, 2024
Feature/word locale
adding const in test values.
cieslarmichal
approved these changes
Oct 2, 2024
cieslarmichal
requested changes
Oct 2, 2024
removing option in words with (length<=256), and s capture the datase…
cieslarmichal
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the word module has incorporate the locale feature. All previous functions (ej, faker::word::sample()) can receive a locale parameter(it is necessary to pass the length argument, ej: sample(7,faker::locale::en_US)).