This repository was archived by the owner on Dec 10, 2024. It is now read-only.
Add Smooth Lyric Animation #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an animation to the lyrics that makes them look more natural.
|
sex.mp4 approved |
cryptofyre
pushed a commit
that referenced
this pull request
May 31, 2022
* app-mainMenu can be triggered by right click Currently you can't open the little Cider popup menu without first uncollapsing the sidebar. This is extremely an extremely unepic sussy amogus L gamer moment. This change allows you to right click to bypass uncollapsing the sidebar and get straight to the hot app-mainMenu action. I think Cider speedrunners will greatly appreciate this quality of life addition. Please consider accepting this PR (short for pull request) to improve the UX (short for user experience). * Improve Smooth Lyric Animation PR #1094 introduced a few issues: A) The animations would be paused when Cider was out of focus, making the lyrics remain grayed out B) The animation was too slow, making it harder to sing along with karaoke mode on faster-paced songs C) The easing method was inconsistent with the rest of the app and made the color look a little janky This PR fixes issue A by changing the animation method from an animation to a transition, fixes B by increasing the speed (which themes can easily adjust if preferred), and fixes C by using the existing var(--appleEase) as the easing method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an animation to the lyrics that makes them look more natural.
sex.mov