chore(): prepare for alternative BpmProvider implementation

[os-cib]

No description provided.

[Copilot]

Pull request overview

This PR refactors the BpmProvider architecture to prepare for alternative implementations by converting SevenProvider from a concrete class with method implementations to a delegating wrapper that exposes sub-providers. The BpmProvider interface is updated with default methods that delegate to specialized provider interfaces (ITaskProvider, IProcessProvider, etc.).

Key changes:

• SevenProvider methods replaced with getter methods that return specialized providers
• BpmProvider interface converted to use default methods with delegation pattern
• Service layer afterPropertiesSet() validation logic removed
• Helper methods changed from protected to public static for reusability
• SevenUserProvider simplified to use BpmProvider interface directly

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 35 comments.

Show a summary per file

File	Description
SevenProvider.java	Removed 1000+ lines of method implementations, replaced with provider getters
BpmProvider.java	Converted to interface with default delegation methods calling getters
ProcessProvider.java	Extracted groupProcessStatisticsByKeyAndTenant to public static helper
SevenProviderBase.java	Changed filterResources visibility to public static
VariableProvider.java	Changed mergeVariablesValues visibility to public static
SevenUserProvider.java	Simplified to use BpmProvider interface instead of casting
Multiple Service classes	Removed SevenProvider validation in afterPropertiesSet()

Critical Issue Found:

• TaskService.java still references and uses the uninitialized sevenProvider field (lines 87, 259), which will cause NullPointerException at runtime
• Multiple service classes declare unused sevenProvider fields that should be removed for code cleanliness

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@param tag "processDefinitionId" does not match any actual parameter of method "fetchDiagram()".

[Copilot]

@param tag "processDefinitionId" does not match any actual parameter of method "downloadBpmn()".

[Copilot]

@param tag "id" does not match any actual parameter of method "findProcessStatistics()".

[Copilot]

@param tag "flowUser" does not match any actual parameter of method "addMemberToGroup()".

[Copilot]

@param tag "flowUser" does not match any actual parameter of method "deleteMemberFromGroup()".

[Copilot]

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 23 comments.

Comments suppressed due to low confidence (12)

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:40

• This method overrides BpmProvider.getSystemProvider; it is advisable to add an Override annotation.

    @Autowired private ISystemProvider systemProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:39

• This method overrides BpmProvider.getBatchProvider; it is advisable to add an Override annotation.

    @Autowired private IBatchProvider batchProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:38

• This method overrides BpmProvider.getJobProvider; it is advisable to add an Override annotation.

    @Autowired private IJobProvider jobProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:37

• This method overrides BpmProvider.getDecisionProvider; it is advisable to add an Override annotation.

    @Autowired private IDecisionProvider decisionProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:36

• This method overrides BpmProvider.getUserProvider; it is advisable to add an Override annotation.

    @Autowired private IUserProvider userProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:35

• This method overrides BpmProvider.getJobDefinitionProvider; it is advisable to add an Override annotation.

    @Autowired private IJobDefinitionProvider jobDefinitionProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:34

• This method overrides BpmProvider.getIncidentProvider; it is advisable to add an Override annotation.

    @Autowired private IIncidentProvider incidentProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:33

• This method overrides BpmProvider.getUtilsProvider; it is advisable to add an Override annotation.

    @Autowired private IUtilsProvider utilsProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:32

• This method overrides BpmProvider.getFilterProvider; it is advisable to add an Override annotation.

    @Autowired private IFilterProvider filterProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:31

• This method overrides BpmProvider.getActivityProvider; it is advisable to add an Override annotation.

    @Autowired private IActivityProvider activityProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:30

• This method overrides BpmProvider.getProcessProvider; it is advisable to add an Override annotation.

    @Autowired private IProcessProvider processProvider;

cibseven-webclient-core/src/main/java/org/cibseven/webapp/providers/SevenProvider.java:29

• This method overrides BpmProvider.getTaskProvider; it is advisable to add an Override annotation.

    @Autowired private ITaskProvider taskProvider;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

@param tag "maxResults," does not match any actual parameter of method "findGroups()".

Suggested change

	* @param maxResults, // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.
	* @param maxResults // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.

[Copilot]

@param tag "type," does not match any actual parameter of method "findAuthorization()".

Suggested change

	* @param id, // Filter by the id.
	* @param type, // Filter by authorization type. (0=global, 1=grant, 2=revoke). See the User Guide for more information about authorization types.
	* @param userIdIn, // Filter by a comma-separated list of userIds.
	* @param groupIdIn, // Filter by a comma-separated list of groupIds.
	* @param resourceType, // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.
	* @param resourceId, // Filter by resource id. * @param sortBy, // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortBy, // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortOrder, // Sort the results in a given order. Values may be asc for ascending order or desc for descending order. Must be used in conjunction with the sortBy parameter.
	* @param firstResult, // Pagination of results. Specifies the index of the first result to return.
	* @param maxResults, // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.
	* @param id // Filter by the id.
	* @param type // Filter by authorization type. (0=global, 1=grant, 2=revoke). See the User Guide for more information about authorization types.
	* @param userIdIn // Filter by a comma-separated list of userIds.
	* @param groupIdIn // Filter by a comma-separated list of groupIds.
	* @param resourceType // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.
	* @param resourceId // Filter by resource id.
	* @param sortBy // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortOrder // Sort the results in a given order. Values may be asc for ascending order or desc for descending order. Must be used in conjunction with the sortBy parameter.
	* @param firstResult // Pagination of results. Specifies the index of the first result to return.
	* @param maxResults // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.

[Copilot]

@param tag "userIdIn," does not match any actual parameter of method "findAuthorization()".

Suggested change

	* @param id, // Filter by the id.
	* @param type, // Filter by authorization type. (0=global, 1=grant, 2=revoke). See the User Guide for more information about authorization types.
	* @param userIdIn, // Filter by a comma-separated list of userIds.
	* @param groupIdIn, // Filter by a comma-separated list of groupIds.
	* @param resourceType, // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.
	* @param resourceId, // Filter by resource id. * @param sortBy, // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortBy, // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortOrder, // Sort the results in a given order. Values may be asc for ascending order or desc for descending order. Must be used in conjunction with the sortBy parameter.
	* @param firstResult, // Pagination of results. Specifies the index of the first result to return.
	* @param maxResults, // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.
	* @param id // Filter by the id.
	* @param type // Filter by authorization type. (0=global, 1=grant, 2=revoke). See the User Guide for more information about authorization types.
	* @param userIdIn // Filter by a comma-separated list of userIds.
	* @param groupIdIn // Filter by a comma-separated list of groupIds.
	* @param resourceType // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.
	* @param resourceId // Filter by resource id.
	* @param sortBy // Sort the results lexicographically by a given criterion. Valid values are id, name and type. Must be used in conjunction with the sortOrder parameter.
	* @param sortOrder // Sort the results in a given order. Values may be asc for ascending order or desc for descending order. Must be used in conjunction with the sortBy parameter.
	* @param firstResult // Pagination of results. Specifies the index of the first result to return.
	* @param maxResults // Pagination of results. Specifies the maximum number of results to return. Will return less results if there are no more results left.

[Copilot]

@param tag "groupIdIn," does not match any actual parameter of method "findAuthorization()".

Suggested change

	* @param groupIdIn, // Filter by a comma-separated list of groupIds.
	* @param groupIdIn // Filter by a comma-separated list of groupIds.

[Copilot]

@param tag "resourceType," does not match any actual parameter of method "findAuthorization()".

Suggested change

	* @param resourceType, // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.
	* @param resourceType // Filter by an integer representation of the resource type. See the User Guide for a list of integer representations of resource types.