Fix dropdown not correctly positioned horizontally when body position is relative #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @mkszepp I see we didn't create a new release yet that includes this change, any chance we could? |
Collaborator
|
Sry i will publish everything on begin of next week |
Collaborator
|
@ArnaudWeyts now released in v8.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We noticed that in certain use cases the dropdown is not correctly positioned horizontally when the body is set to
position: relativeand you scroll horizontally. When digging through some issues and the code I discovered this fix for vertical positioning. I believe that we should also implement a similar fix for horizontal positioning. We've patched this dependency in our own app and have verified that it works.Reproducible use case (scroll to the right, then open a dropdown): https://stackblitz.com/edit/ember-cli-editor-output-1hdarw?file=app%2Ftemplates%2Fapplication.hbs,app%2Fstyles%2Fapp.css,app%2Fapp.js&title=Ember%20Starter