Skip to content

Fix #196 #207 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2014
Merged

Fix #196 #207 #211

merged 1 commit into from
Aug 8, 2014

Conversation

zedgu
Copy link
Contributor

@zedgu zedgu commented Aug 8, 2014

test code added and passed

This was referenced Aug 8, 2014
@ciaranj
Copy link
Owner

ciaranj commented Aug 8, 2014

Looks good (thanks for the test) can we squash the two commits though please ?

tests/oauth2.js
  [remove] https never used
  [add] https url testing
lib/oauth2.js
  [remove] creds never used
@zedgu
Copy link
Contributor Author

zedgu commented Aug 8, 2014

one commit now.

ciaranj added a commit that referenced this pull request Aug 8, 2014
Fix #196 #207 (Removes some un-needed calls to tls/crypto)
@ciaranj ciaranj merged commit 69b0b7c into ciaranj:master Aug 8, 2014
@ciaranj
Copy link
Owner

ciaranj commented Aug 8, 2014

Perfect. Thank you :)

@zedgu
Copy link
Contributor Author

zedgu commented Aug 8, 2014

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants