fix: flowgraph crash when channel releasing (milvus-io#37285)

issue: milvus-io#37284 Signed-off-by: chyezh <chyezh@outlook.com>
chyezh · Oct 31, 2024 · 448cc08 · 448cc08
1 parent f13faa3
commit 448cc08
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/datanode/channel/channel_manager.go b/internal/datanode/channel/channel_manager.go
@@ -75,10 +75,11 @@ func NewChannelManager(pipelineParams *util.PipelineParams, fgManager pipeline.F
 			if pipelineParams.CompactionExecutor != nil {
 				pipelineParams.CompactionExecutor.DiscardPlan(channelName)
 			}
+			// RemoveFlowgraph before remove WriteBuffer, otherwise panics will happen.
+			fgManager.RemoveFlowgraph(channelName)
 			if pipelineParams.WriteBufferManager != nil {
 				pipelineParams.WriteBufferManager.RemoveChannel(channelName)
 			}
-			fgManager.RemoveFlowgraph(channelName)
 		},
 
 		closeCh: lifetime.NewSafeChan(),