Add function for get ManufacturerData and AdvertisingData #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @chrvadala, Could you please review this PR and let us know if it is OK to merge? Thank you in advance! |
chrvadala
approved these changes
Apr 14, 2024
Owner
chrvadala
left a comment
chrvadala
left a comment
There was a problem hiding this comment.
Ready to merge. Releasing in the next days
Owner
|
Released with v1.11. I had to change few things with this commit 4d857fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function for get ManufacturerData and AdvertisingData to the Device Interface.
This is the same as PR #61 with the changes commented here #53. I created a new pull-request because the #61 was not made by me.