Is there a specific reason to undef HOST_NOT_FOUND?

[MrJia1997]

Just wonder. Is there a specific reason to undef HOST_NOT_FOUND? What's the problem if it's still defined?

FastBinaryEncoding/proto/fbe.h

Line 44 in b1f5223

#undef HOST_NOT_FOUND

[chronoxor]

Quick answer - we have HOST_NOT_FOUND duplicate in one of our projects and we want a quick solution for this issue 😊(https://emojipedia.org/smiling-face-with-smiling-eyes)

[chronoxor]

But other definitions from Winapi.h must be undefined anyway, because they are duplicates even with std libraries (e.g. std::min, std::max):

#undef DELETE
#undef ERROR
#undef Yield
#undef min
#undef max
#undef uuid_t

[MrJia1997]

Thank you for your prompt response! The reason why I ask this is that HOST_NOT_FOUND is also used in netdb.h on Linux, and undefine it will cause some other libraries to not work, e.g., Asio.

[chronoxor]

Probably I'll remove it soon. Thanks for pointing on this!

[chronoxor]

Fixed in FBE 1.14.5.0