Move the datetime::serde timestamp visitors into the respective modules
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules The internal structs can be moved into their respective modules because `pub(super)` is now supported by the MSRV.
|
This looks like a good change but I'm a little worried about Hyrum's law (and it doesn't seem that urgent/important), so I'd like to postpone this until at least after the 0.4.20 release and maybe to 0.5. Any thoughts on that? |
sure, I'm fine with it. |
esheppa
added
the
API-incompatible
esheppa
approved these changes
Sep 8, 2022
|
This looks good to me - are you happy to have this merged @djc? |
|
Yes! Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal structs can be moved into their respective modules because
pub(super)is now supported by the MSRV.This is technically a breaking change but these structs were hidden from the docs.