Add Default implementation for naive date types #506
Conversation
…Time * Added Default implmentation for DateTime and Date
|
Sorry for the delay! I agree that this is just kind of annoying to have not-implemented, and just using the unix epoch makes sense as a reasonably-surprising value. If you're willing to fix the tests and add implementations of this for the non-naive |
|
Hi @quodlibetor , sorry for my late reply, yes I'm more than happy to do that! I'll update the PR once I have the changes. |
|
Hi @quodlibetor, the test now pass and I've added |
src/naive/time.rs
Outdated
| @@ -1341,6 +1341,20 @@ impl str::FromStr for NaiveTime { | |||
| } | |||
| } | |||
|
|
|||
| /// The default for a NaiveTime is midnight, oo:oo:00 exactly. | |||
There was a problem hiding this comment.
these are the letter o instead of the number 0
src/naive/date.rs
Outdated
| /// | ||
| /// # Example | ||
| /// | ||
| /// ~~~~ |
There was a problem hiding this comment.
we recently (in between your submission of this PR and now) swapped all the doctests to use backticks to be more inline with other rust code. If you feel like changing these that'd be appreciated, but your call.
There was a problem hiding this comment.
I've changed the docs from the Default impl to use backticks!
* Fixed typo in NaiveTime docs for Default
|
Hello @quodlibetor hope you had a nice holiday, I simply wanted to know if anything more was required in order to have the PR merge onto master, happy to make any changes if needed! |
|
Thank you! |
|
I think |
This PR aims to add some Default implementations for some of the naive types. The currently added defaults are the following:
NaiveDateTimehas been set to1970-01-01 00:00:00NaiveDatehas been set to1970-01-01NaiveTimehas been set to00:00:00The main reason for the PR is to help in struct definitions that wish to simply
#derive[Default]but currently are not able to because on of their attributes is of the previously mentioned types, adding this change would help simplify the code in that particular scenario.