-
Notifications
You must be signed in to change notification settings - Fork 589
Add num_days_in_month
method to Datelike
trait
#1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
+ Coverage 91.06% 91.08% +0.01%
==========================================
Files 37 37
Lines 17454 17469 +15
==========================================
+ Hits 15895 15912 +17
+ Misses 1559 1557 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits into clean history:
- One for the
in_leap_year()
addition - One for adding
num_days_in_month()
3cc0e67
to
9c2f78e
Compare
9c2f78e
to
97ee174
Compare
Thanks! |
The recent
num_days
addition to theMonth
type is great, but it could be even better if we took it just a little bit further.This change adds a
num_days_in_month
function to theDatelike
trait.