Skip to content

Conversation

aslilac
Copy link
Contributor

@aslilac aslilac commented Mar 9, 2025

The recent num_days addition to the Month type is great, but it could be even better if we took it just a little bit further.

This change adds a num_days_in_month function to the Datelike trait.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (fa957cc) to head (97ee174).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
+ Coverage   91.06%   91.08%   +0.01%     
==========================================
  Files          37       37              
  Lines       17454    17469      +15     
==========================================
+ Hits        15895    15912      +17     
+ Misses       1559     1557       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into clean history:

  • One for the in_leap_year() addition
  • One for adding num_days_in_month()

@aslilac aslilac force-pushed the lilac/num_days_in_month branch from 9c2f78e to 97ee174 Compare March 15, 2025 18:05
@djc djc merged commit 39fb201 into chronotope:main Mar 17, 2025
35 checks passed
@djc
Copy link
Member

djc commented Mar 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants