Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include doctests for code coverage #1248

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

pitdicker
Copy link
Collaborator

This requires nightly, see taiki-e/cargo-llvm-cov#2.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #1248 (2d575b8) into 0.4.x (ecfad9e) will increase coverage by 5.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1248      +/-   ##
==========================================
+ Coverage   85.82%   91.41%   +5.59%     
==========================================
  Files          37       37              
  Lines       13517    16452    +2935     
==========================================
+ Hits        11601    15040    +3439     
+ Misses       1916     1412     -504     

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker
Copy link
Collaborator Author

Code coverage increased from 85.82% to 91.41% 🚀.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's a pretty cheap win!

Do we know why it needs nightly? Is there some tracking issue I could follow?

@pitdicker
Copy link
Collaborator Author

I am not sure what would be the right issue to track.
https://doc.rust-lang.org/rustc/instrument-coverage.html#including-doc-tests mentions code coverage relies on the -Z unstable-options --persist-doctests. So either that must be stabilized (tracking issue rust-lang/rust#56925), or code coverage must switch to something different.
taiki-e/cargo-llvm-cov#2 seems easier to follow for updates.

@pitdicker pitdicker merged commit 1b25e47 into chronotope:0.4.x Sep 3, 2023
37 checks passed
@pitdicker pitdicker deleted the code_coverage_doctests branch September 3, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants