Skip to content

Commit

Permalink
lock in serde versions in dev deps to avoid msrv issues
Browse files Browse the repository at this point in the history
  • Loading branch information
esheppa committed Apr 22, 2023
1 parent d7b96c6 commit 3eeb60c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ jobs:
- uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.38.0
# - uses: Swatinem/rust-cache@v2
# - run: cargo clean
- uses: Swatinem/rust-cache@v2
# run --lib and --doc to avoid the long running integration tests which are run elsewhere
- run: cargo test --lib --features unstable-locales,wasmbind,oldtime,clock,rustc-serialize,winapi --color=always -- --color=always
- run: cargo test --doc --features unstable-locales,wasmbind,oldtime,clock,rustc-serialize,winapi --color=always -- --color=always
Expand Down
5 changes: 3 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ winapi = { version = "0.3.0", features = ["std", "minwinbase", "minwindef", "tim
iana-time-zone = { version = "0.1.45", optional = true, features = ["fallback"] }

[dev-dependencies]
serde_json = { version = "1" }
serde_derive = { version = "1", default-features = false }
# serde_json and serde_derive are locked at the most recent version compatible with 1.38.0 MSRV
serde_json = { version = "=1.0.96" }
serde_derive = { version = "=1.0.156", default-features = false }
bincode = { version = "1.3.0" }
num-iter = { version = "0.1.35", default-features = false }
doc-comment = { version = "0.3" }
Expand Down

0 comments on commit 3eeb60c

Please sign in to comment.