Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Hash for Tz #14

Merged
merged 2 commits into from
Jun 29, 2018
Merged

impl Hash for Tz #14

merged 2 commits into from
Jun 29, 2018

Conversation

donhcd
Copy link
Contributor

@donhcd donhcd commented Dec 21, 2017

No description provided.

@mhseiden mhseiden mentioned this pull request Apr 9, 2018
Closed
quodlibetor
quodlibetor requested changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@quodlibetor quodlibetor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR and I am extremely sorry that I missed it. I didn't have maintainership of this repo until recently and I forgot to turn on notifications :-(

One small tweak and I'll release this.

src/lib.rs Outdated

#[test]
fn test_impl_hash() {
#[derive(Hash)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you throw an #[allow(dead_code)] in here so that we don't get compiler warnings every time we test?

@quodlibetor quodlibetor merged commit a973029 into chronotope:master Jun 29, 2018
@quodlibetor
Copy link
Contributor

Actually I spoke too soon about being able to release this. @djzin I've published a version bump to master, could you run cargo publish?

Additionally @djzin if you wanted to run cargo owner --add github:chronotope:release-manager and I'll be able to do this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quodlibetor quodlibetor quodlibetor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donhcd @quodlibetor