feat: accelerated paint #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why this specifically? whats wrong with other merge methods |
It bloats up the commit history, and my changes are so small that they wouldn't benefit from a traditional merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEF supports hardware-accelerated off-screen rendering by enabling
shared_texture_enabledviaWindowInfoand passing--off-screen-rendering-enabled --shared-texture-enabledas arguments.Unfortunately, Java CEF lacks bindings for OnAcceleratedPaint, meaning we cannot make use of this feature. This pull request enables this feature when turning
shared_texture_enabledto true.The changes were tested on a forked JCEF version (on Update to CEF 135.0.20+ge7de5c3+chromium-135.0.7049.85) by converting the D3D11 shared texture handle using
ImportMemoryWin32HandleEXTusing OpenGL's EXT_external_objects_win32 which is supported by LWJGL3.Ignore the inverted colors. It was still missing the shader for the color conversion.
Fixes #506
Please "Squash And Merge" (!!!).