Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cefclient: alloy: Popup window non-responsive when using --use-default-popup #3499

Closed
stephanema1 opened this issue May 8, 2023 · 6 comments
Labels
alloy-style Related to Chrome runtime + Alloy style bug Bug report cefclient Related to the cefclient sample app chrome Related to the Chrome runtime native Related to a native (non-Views) framework SampleApps Related to sample apps

Comments

@stephanema1
Copy link

Describe the bug
This bug is already described in cefsharp/CefSharp#4488 .

To Reproduce
Steps to reproduce the behavior:

  1. download https://cef-builds.spotifycdn.com/cef_binary_113.1.1%2Bgfef20aa%2Bchromium-113.0.5672.63_windows64_beta_client.tar.bz2
  2. run cefclient.exe --multi-threaded-message-loop --no-sandbox --enable-gpu --use-default-popup
  3. Open a Website/html file with a link to a pdf line <a href="test.pdf" target="_blank">test.pdf</a>
  4. cklick on the test.pdf link, the pdf is shown in a second window.
  5. close the first windows (mein window)
  6. the second window with the pdf now schows only black content and the process never closes
    (you kann only kill it with the task manager)

Expected behavior
When I execute the step 5. from above I expect that all windows are closed and that the process terminates.

Screenshots

Versions (please complete the following information):

  • OS: Windows 10 (21H2)
  • CEF Version: 110.0 or the actual beta (I suppose all are affected)

Additional context
Does the problem reproduce with the cefclient or cefsimple sample application at the same version?
Yes

Does the problem reproduce with Google Chrome at the same version?
No

Add any other context about the problem here.

@stephanema1 stephanema1 added the bug Bug report label May 8, 2023
@magreenblatt
Copy link
Collaborator

A similar issue reproduces with:

  1. Run cefclient.exe --use-default-popup
  2. Select Tests > New Popup
  3. Close the main window
  4. Notice that the remaining popup window is unresponsive

@magreenblatt magreenblatt changed the title Open a pdf by click on a link with target="_blank" in a second window hangs after closing mainwindow cefclient: Popup window non-responsive when using --use-default-popup May 9, 2023
@magreenblatt magreenblatt added cefclient Related to the cefclient sample app SampleApps Related to sample apps labels May 9, 2023
@magreenblatt
Copy link
Collaborator

cefclient.exe --use-default-popup works fine for me in M116 and newer (both Alloy and Chrome).

@magreenblatt
Copy link
Collaborator

OOPS, missed the bit about "Close the main window"

@magreenblatt magreenblatt reopened this Nov 11, 2023
@magreenblatt magreenblatt added the alloy Related to the Alloy runtime label Nov 11, 2023
@magreenblatt magreenblatt changed the title cefclient: Popup window non-responsive when using --use-default-popup cefclient: alloy: Popup window non-responsive when using --use-default-popup Nov 11, 2023
@magreenblatt
Copy link
Collaborator

Works fine with Chrome, still an issue for Alloy.

@magreenblatt
Copy link
Collaborator

magreenblatt commented Aug 5, 2024

This is currently crashing at M128 in RootWindowViews::GetDelegateForPopup due to an invalid cast. |client| is a DefaultClientHandler instead of a ClientHandlerStd

@magreenblatt
Copy link
Collaborator

magreenblatt commented Aug 5, 2024

This still reproduces at M128 (tested on Windows 11):

  1. Run cefclient.exe --use-alloy-style --use-native --use-default-popup
  2. Select Tests > New Popup
  3. Close the main window
  4. Notice that the remaining popup window is unresponsive

Using --use-alloy-style --use-views --use-default-popup the popup window contents are black after step 2.

None of this reproduces after removing --use-alloy-style.

@magreenblatt magreenblatt added native Related to a native (non-Views) framework alloy-style Related to Chrome runtime + Alloy style chrome Related to the Chrome runtime and removed alloy Related to the Alloy runtime labels Aug 5, 2024
magreenblatt added a commit that referenced this issue Oct 18, 2024
Don't depend on a CefBrowserViewDelegate for popup BrowserView style.
Popup style must always match the opener style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alloy-style Related to Chrome runtime + Alloy style bug Bug report cefclient Related to the cefclient sample app chrome Related to the Chrome runtime native Related to a native (non-Views) framework SampleApps Related to sample apps
Projects
None yet
Development

No branches or pull requests

2 participants