Win/Linux: Ship vk_swiftshader.dll vulkan-1.dll vk_swiftshader_icd.json for M91+

[magreenblatt]

Original report by Yonggang Luo (Bitbucket: lygstate, GitHub: lygstate).

---

The new version chrome have the following vulkan software render shipped

2021/08/28  04:38         4,590,424 vk_swiftshader.dll
2021/08/28  04:10               106 vk_swiftshader_icd.json
2021/08/28  04:38           728,920 vulkan-1.dll

‌

[magreenblatt]

Related Chromium change: https://crrev.com/ded0a1bc46

[magreenblatt]

• changed title from "Ship vk_swiftshader.dll vulkan-1.dll vk_swiftshader_icd.json for chrome 92 and upper" to "Win/Linux: Ship vk_swiftshader.dll vulkan-1.dll vk_swiftshader_icd.json for M92+"
• changed component from "Unclassified" to "Distribution"

[magreenblatt]

The change was also merged to Chromium M91.

[magreenblatt]

• changed title from "Win/Linux: Ship vk_swiftshader.dll vulkan-1.dll vk_swiftshader_icd.json for M92+" to "Win/Linux: Ship vk_swiftshader.dll vulkan-1.dll vk_swiftshader_icd.json for M91+"

[magreenblatt]

From https://bugs.chromium.org/p/chromium/issues/detail?id=1060139#c77 (M92+):

Currently, Chrome uses legacy SwiftShader GL as the WebGL fallback when
a hardware GPU isn't usable for the purpuse of rendering WebGL content.

As we're in the process of changing legacy SwiftShader GL to SwANGLE,
this CL adds a new flag which allows using SwANGLE for WebGL only.

To clarify, current switches with legacy SwiftShader GL:
Software GL: --use-gl=swiftshader
Software WebGL only: --use-gl=swiftshader-webgl

With SwANGLE, the new switches will be:
Software GL: --use-gl=angle --use-angle=swiftshader
Software WebGL only: --use-gl=angle --use-angle=swiftshader-webgl

I would guess the intention is to stop shipping the “swiftshader” directory, but the timeframe for that is unclear.

[magreenblatt]

Based on the logic in GetRequestedGLImplementation it should use whichever software impl is available, preferring the new angle impl by default.

[magreenblatt]

I’m inclined to wait on shipping these new files until swiftshader is deprecated/removed. If anyone will need these files sooner please explain the reason. Thanks.

[magreenblatt]

Original comment by Alex Maitland (Bitbucket: a-maitland).

---

Based on the logic in GetRequestedGLImplementation it should use whichever software impl is available, preferring the new angle impl by default.

Possibly an instance where this isn’t working as expected at https://magpcss.org/ceforum/viewtopic.php?f=18&t=18661

‌

[magreenblatt]

Thanks for the link. It may be worth a look at why the fallback logic in Chromium isn’t working.

[magreenblatt]

Original comment by Alex Maitland (Bitbucket: a-maitland).

---

Another log file with vulkan errors at cefsharp/CefSharp#3833 (not clear yet if they are related to the issue reported).

The required files appear to be generated as part of an official release build. Is there a reason to defer shipping them?

[magreenblatt]

Is there a reason to defer shipping them?

Not really, beyond the (prior) belief that they were redundant with the swiftshader libraries. I don’t really like shipping two rather large sets of optional binaries that do mostly the same thing. Perhaps we can just stop shipping swiftshader now, instead of waiting.

[magreenblatt]

Looks like we’ll need to ship these new binaries with M94+ because some content now fails to render via software that rendered previously (circa M91).

[magreenblatt]

Original comment by Dmitry Azaraev (Bitbucket: dmitry-azaraev, GitHub: dmitry-azaraev).

---

I’m migrated to CEF 93 and start to ship vk_swiftshader.dll, vk_swiftshader_icd.json, vulkan-1.dll because CEF with --disable-gpu switch works, but WebGL effectively is not (like described in this issue). Chrome 94 still ship all of this binaries, so this would be easier and fair to ship this things regardless to how them used in practice. [Peoples who require hardware GPU always can exclude this from distribution, as deploy optimization, but rest of users never know what and how GPU fallback work.]

Diff below looks like enough to ship them:

diff --git tools/make_distrib.py tools/make_distrib.py
index [838bc1834 (bb)](https://bitbucket.org/chromiumembedded/cef/commits/838bc1834)..a5f37a30d [100644 (bb)](https://bitbucket.org/chromiumembedded/cef/commits/100644)
--- tools/make_distrib.py
+++ tools/make_distrib.py
@@ -862,6 +862,9 @@ if platform == 'windows':
       {'path': 'v8_context_snapshot.bin', 'conditional': True},
       {'path': 'swiftshader\\libEGL.dll'},
       {'path': 'swiftshader\\libGLESv2.dll'},
+      {'path': 'vk_swiftshader.dll'},
+      {'path': 'vk_swiftshader_icd.json'},
+      {'path': 'vulkan-1.dll'},
   ]
   # yapf: enable
 

‌

[magreenblatt]

Distribute binaries for SwANGLE support (fixes issue #3176)

Adds SwANGLE libraries that are required for software rendering on Windows
and Linux. Updates README.txt documentation accordingly.

→ <<cset 582e0a0ab78a (bb)>>

[magreenblatt]

• changed state from "new" to "resolved"