Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputDir to GitHub Action options #1136

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Jan 8, 2025

Closes #1135

Simply adds the outputDir option to our GitHub Action so buildCommand can work properly.

📦 Published PR as canary version: 11.22.2--canary.1136.12678465081.0

✨ Test out this PR locally via:

npm install chromatic@11.22.2--canary.1136.12678465081.0
# or 
yarn add chromatic@11.22.2--canary.1136.12678465081.0

@codykaup codykaup self-assigned this Jan 8, 2025
@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

📦 Package Size: 5448 KB

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (43a9b94) to head (fae3fae).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
action-src/main.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   69.40%   69.38%   -0.02%     
==========================================
  Files         202      202              
  Lines        7319     7321       +2     
  Branches     1278     1280       +2     
==========================================
  Hits         5080     5080              
- Misses       2216     2218       +2     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codykaup codykaup requested a review from a team January 8, 2025 19:31
@codykaup codykaup added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@codykaup codykaup added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit c8530c9 Jan 8, 2025
22 of 26 checks passed
@codykaup codykaup deleted the cody/cap-2623-outputdir-is-not-available-as-an-option-in-the-github-action branch January 8, 2025 20:24
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.22.1 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputDir is not available as an option in the github action
3 participants