-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --build-command
for arbitrary build commands
#1109
Add support for --build-command
for arbitrary build commands
#1109
Conversation
📦 Package Size: 5380 KB |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
nx
commands via --build-command
option--build-command
for arbitrary build commands
11207e9
to
6c57be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sounds to me, don't forget the docs site!
a72c761
to
a1c1456
Compare
🚀 PR was released in |
Some monorepos are using
nx
to manage everything and they don't have a "scripts" field in theirpackage.json
. This prevents our visual tests addon from working.To fix that issue, this introduces a new
--build-command
flag which can accept a full command to build the Storybook so you can do something like📦 Published PR as canary version:
11.17.0--canary.1109.11520237164.0
✨ Test out this PR locally via:
npm install chromatic@11.17.0--canary.1109.11520237164.0 # or yarn add chromatic@11.17.0--canary.1109.11520237164.0