Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --build-command for arbitrary build commands #1109

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Oct 23, 2024

Some monorepos are using nx to manage everything and they don't have a "scripts" field in their package.json. This prevents our visual tests addon from working.

To fix that issue, this introduces a new --build-command flag which can accept a full command to build the Storybook so you can do something like

yarn nx run my-app:build-storybook
📦 Published PR as canary version: 11.17.0--canary.1109.11520237164.0

✨ Test out this PR locally via:

npm install chromatic@11.17.0--canary.1109.11520237164.0
# or 
yarn add chromatic@11.17.0--canary.1109.11520237164.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Oct 23, 2024
@codykaup codykaup self-assigned this Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

📦 Package Size: 5380 KB

Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 013a4021 65.52% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (013a402) Report Missing Report Missing Report Missing
Head commit (a1c1456) 7113 4836 67.99%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1109) 29 19 65.52%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codykaup codykaup changed the title Add support for nx commands via --build-command option Add support for --build-command for arbitrary build commands Oct 23, 2024
@codykaup codykaup force-pushed the cody/cap-2103-users-that-have-monorepos-such-as-nx-cannot-use-the-vtaddon branch from 11207e9 to 6c57be1 Compare October 23, 2024 20:49
@codykaup codykaup marked this pull request as ready for review October 23, 2024 21:23
@codykaup codykaup requested a review from a team October 23, 2024 21:23
Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sounds to me, don't forget the docs site!

@codykaup codykaup force-pushed the cody/cap-2103-users-that-have-monorepos-such-as-nx-cannot-use-the-vtaddon branch from a72c761 to a1c1456 Compare October 24, 2024 17:08
@codykaup codykaup added release Auto: Create a `latest` release when merged and removed skip-release Auto: Preserve the current version when merged labels Oct 25, 2024
@codykaup codykaup added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 69372e2 Oct 25, 2024
23 of 24 checks passed
@codykaup codykaup deleted the cody/cap-2103-users-that-have-monorepos-such-as-nx-cannot-use-the-vtaddon branch October 25, 2024 14:32
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.16.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants