Fix diagnostic flag parsing

chromaui · Nov 1, 2024 · d66dee9 · d66dee9
1 parent db3848b
commit d66dee9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/node-src/lib/getOptions.test.ts b/node-src/lib/getOptions.test.ts
@@ -209,4 +209,10 @@ describe('getOptions', () => {
       uploadMetadata: true,
     });
   });
+
+  it('allows you to specify a diagnostics file name', async () => {
+    expect(getOptions(getContext(['--diagnostics-file', 'output.json']))).toMatchObject({
+      diagnosticsFile: 'output.json',
+    });
+  });
 });
diff --git a/node-src/lib/getOptions.ts b/node-src/lib/getOptions.ts
@@ -141,11 +141,9 @@ export default function getOptions(ctx: InitialContext): Options {
     forceRebuild: trueIfSet(flags.forceRebuild),
     debug: flags.debug,
     diagnosticsFile:
-      defaultIfSet(flags.diagnosticsFile, DEFAULT_DIAGNOSTICS_FILE) ||
+      defaultUnlessSetOrFalse(flags.diagnosticsFile, DEFAULT_DIAGNOSTICS_FILE) ||
       // for backwards compatibility
-      flags.diagnostics
-        ? DEFAULT_DIAGNOSTICS_FILE
-        : undefined,
+      (flags.diagnostics ? DEFAULT_DIAGNOSTICS_FILE : undefined),
     junitReport: defaultIfSet(flags.junitReport, DEFAULT_REPORT_FILE),
     zip: flags.zip,
     skipUpdateCheck: flags.skipUpdateCheck,