[ENH] add Rust bindings #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
HammadB
approved these changes
Feb 18, 2025
codetheweb
added a commit
to chroma-core/chroma
that referenced
this pull request
Feb 18, 2025
## Description of changes Requires chroma-core/hnswlib#30 (CI will not pass until that PR is merged). Moves bindings to our fork of hnswlib. This means that the hnswlib repo will no longer need to be a sibling of this repo for it to build correctly. ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust Moved Rust tests for bindings to hnswlib repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Rust binding layer into this repo from https://github.com/chroma-core/chroma.
Decided to move the bindings here rather than moving the contents of this repo into chroma-core/chroma as going in the other direction muddies the CI in chroma-core/chroma. This also allows us to easily continue publishing the Python bindings.
This crate will be consumed via a git dependency. I do not plan on publishing it to crates.io in the near future.