build: add flake8-tidy-imports to ban relative imports #6093
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #2334
This PR adds
flake8-tidy-importsto the pre-commit flake8 hook with the--ban-relative-imports=trueflag to enforce absolute imports throughout the codebase.Changes
flake8-tidy-imports>=4.10.0as an additional dependency to the flake8 pre-commit hook--ban-relative-imports=trueargument to enforce absolute importsWhy?
Test plan
The pre-commit hook will now flag any relative imports (e.g.,
from . import fooorfrom .module import bar).