Skip to content

[HOTFIX] applying PR #5282 to release/2025-08-08 #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[HOTFIX] applying PR #5282 to release/2025-08-08 #5290

merged 1 commit into from
Aug 15, 2025

Conversation

chroma-droid
Copy link

This PR cherry-picks the commit 8965232 onto release/2025-08-08. If there are unresolved conflicts, please resolve them manually.

@rescrv @propel-code-bot @github-actions
[BUG] CompactionError did not proxy should_trace_error (#5282)
1638988 
## Description of changes

Somehow I missed this path for soft deletes.

## Test plan

Unfortunately, observability plan.

## Migration plan

N/A

## Observability plan

See the errors go away or not.

## Documentation Changes

N/A

---------

Co-authored-by: propel-code-bot[bot] <203372662+propel-code-bot[bot]@users.noreply.github.com>
@chroma-droid chroma-droid requested a review from rescrv August 15, 2025 23:14
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv merged commit 4483994 into release/2025-08-08 Aug 15, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rescrv rescrv rescrv approved these changes

Assignees

@rescrv rescrv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chroma-droid @rescrv