[BUG] Mark dirty on rollback of cursor to guarantee compaction picks it up.

[rescrv]

Description of changes

The tests flaked because compaction is now faster. This will make the
test robust, but also make it so that DR does the right thing.

Test plan

CI

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

This pull request modifies the log service to explicitly mark a collection as dirty when a rollback of the compaction cursor occurs, ensuring that downstream compaction will correctly detect and process the collection as needing compaction. This change is a response to tests flaking due to compaction running faster, and also aligns the dirty log (DR) behavior to match compaction requirements. The change is limited to a conditional insertion of a 'dirty' marker during rollback scenarios.

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[BestPractice]

Consider extracting the MarkDirty creation into a helper method or storing it as a field in the struct, since this exact pattern (creating MarkDirty with collection_id and Arc::clone(&self.dirty_log)) appears multiple times throughout the codebase.

Suggested change

	if allow_rollback {
	let mark_dirty = MarkDirty {
	collection_id,
	dirty_log: Arc::clone(&self.dirty_log),
	};
	let _ = mark_dirty
	.mark_dirty(LogPosition::from_offset(adjusted_log_offset as u64), 1usize)
	.await;
	}
	if allow_rollback {
	let mark_dirty = MarkDirty {
	collection_id,
	dirty_log: Arc::clone(&self.dirty_log),
	};
	if let Err(err) = mark_dirty
	.mark_dirty(LogPosition::from_offset(adjusted_log_offset as u64), 1usize)
	.await
	{
	tracing::warn!("Failed to mark dirty during rollback: {}", err);
	}
	}

This change adds error logging since marking dirty during rollback operations could be important for debugging if it fails.

⚡ Committable suggestion

Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.