Skip to content

[ENH] Allow scorecarding of fork collection by collection or tenant. #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Aug 11, 2025

Description of changes

This adds the collection ID to the tags available for scorecarding
requests for the fork_collection call.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

This PR augments the scorecarding mechanism for the fork_collection operation in the server frontend, adding the involved collection ID to the scorecard request tags alongside the operation and tenant. This change allows for more granular metering and tracking of operations on a per-collection and per-tenant basis during the forking of a collection.

This summary was automatically generated by @propel-code-bot

@rescrv rescrv requested a review from Sicheng-Pan August 11, 2025 21:19
@rescrv rescrv merged commit cbb510c into main Aug 11, 2025
60 checks passed
@rescrv rescrv deleted the rescrv/scorecard-fork-collection branch August 11, 2025 21:55
chroma-droid pushed a commit that referenced this pull request Aug 11, 2025
…5247)

## Description of changes

This adds the collection ID to the tags available for scorecarding
requests for the `fork_collection` call.

## Test plan

CI

## Migration plan

N/A

## Observability plan

N/A

## Documentation Changes

N/A
rescrv added a commit that referenced this pull request Aug 13, 2025
This PR cherry-picks the commit cbb510c
onto release/2025-08-08. If there are unresolved conflicts, please
resolve them manually.

Co-authored-by: Robert Escriva <robert@trychroma.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant