Skip to content

[CLN]: Remove spammy logs of spann compaction #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CLN]: Remove spammy logs of spann compaction #5161

merged 1 commit into from
Jul 29, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jul 29, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removes log lines emitted during spann compaction that were spammy
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

None

Observability plan

Monitor in local tilt

Documentation Changes

None

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia marked this pull request as ready for review July 29, 2025 16:45
@propel-code-bot propel-code-bot
Copy link
Contributor

This PR removes several redundant and verbose log statements from the spann compaction logic in rust/index/src/spann/types.rs. The intention is to reduce log noise generated during routine compaction and operational flows, making logs cleaner and more actionable without impacting core functionality.

This summary was automatically generated by @propel-code-bot

@sanketkedia sanketkedia merged commit d359d09 into main Jul 29, 2025
61 checks passed
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
@sanketkedia @Inventrohyder
[CLN]: Remove spammy logs of spann compaction (chroma-core#5161)
d1506c4 
## Description of changes

_Summarize the changes made by this PR._

- Improvements & Bug fixes
  - Removes log lines emitted during spann compaction that were spammy
- New functionality
  - ...

## Test plan

_How are these changes tested?_
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan
None

## Observability plan
Monitor in local tilt

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB