Skip to content

[DOC] Add ids to query parameters in docs #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Jul 25, 2025

Description of changes

This PR updates docs with reference to ids as part of the query parameters

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 jairad26 marked this pull request as ready for review July 25, 2025 17:11
Copy link
Contributor

propel-code-bot bot commented Jul 25, 2025

This PR updates the documentation in multiple files to reflect the availability of an 'ids' parameter for query operations in both Python and JS/TS Collection APIs. It clarifies that 'ids' can now be used to limit the query search space and provides accurate type signatures, argument details, and usage examples across reference docs.

This summary was automatically generated by @propel-code-bot

@jairad26 jairad26 enabled auto-merge (squash) July 25, 2025 17:13
@jairad26 jairad26 closed this Jul 25, 2025
auto-merge was automatically disabled July 25, 2025 17:30

Pull request was closed

@jairad26 jairad26 reopened this Jul 25, 2025
@jairad26 jairad26 enabled auto-merge (squash) July 25, 2025 17:31
@jairad26 jairad26 force-pushed the jai/update-query-ids-docs branch from 6d33fcc to aa6e2f6 Compare July 25, 2025 19:41
@jairad26 jairad26 merged commit ac0397b into main Jul 25, 2025
114 of 116 checks passed
@blacksmith-sh blacksmith-sh bot deleted a comment from jairad26 Jul 25, 2025
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

This PR updates docs with reference to ids as part of the query
parameters

## Test plan

_How are these changes tested?_

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Migration plan

_Are there any migrations, or any forwards/backwards compatibility
changes needed in order to make sure this change deploys reliably?_

## Observability plan

_What is the plan to instrument and monitor this change?_

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants