[ENH]: return error on /add if embeddings are not provided #5033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This PR adds server-side validation to the /add endpoint, ensuring an error is returned when embeddings are not provided in the AddCollectionRecordsPayload. A new ValidationError variant, MissingEmbeddings, was introduced and mapped to an invalid argument error code. This summary was automatically generated by @propel-code-bot |
chroma-droid
pushed a commit
that referenced
this pull request
Jul 6, 2025
## Description of changes Our official clients prevent this but the server does not have a check. A better solution is making `AddCollectionRecordsPayload.embddings` non-optional, but this works as a minimal patch for now. ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_ n/a
codetheweb
added a commit
that referenced
this pull request
Jul 6, 2025
This PR cherry-picks the PR #5033 onto release/2025-06-27. If there are unresolved conflicts, please resolve them manually.
1 task
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…re#5033) ## Description of changes Our official clients prevent this but the server does not have a check. A better solution is making `AddCollectionRecordsPayload.embddings` non-optional, but this works as a minimal patch for now. ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_ n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Our official clients prevent this but the server does not have a check. A better solution is making
AddCollectionRecordsPayload.embddingsnon-optional, but this works as a minimal patch for now.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
n/a