-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[CLN] Add max_batch_size to sqlite_log, use in push_logs #5010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
778eca5
to
89bf55b
Compare
Remove push_logs_batch_size from Sqlite Config, Use get_max_batch_size() This PR removes the push_logs_batch_size parameter from the SqliteDBConfig and related usage in the codebase, migrating batch sizing for sqlite push_logs operations to dynamically use the computed max batch size via get_max_batch_size(). Associated struct fields, defaults, and constructor parameters are updated for consistency, and usage of batch size in push_logs is refactored. The PR also includes a small conversion utility for ScalarEncoding to String. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
b6aea1e
to
d7f6f55
Compare
d7f6f55
to
38b9c72
Compare
…#5010) ## Description of changes This PR removes the push_logs_batch_size from sqlite config, and replaces it with max_batch_size. It sets up with OnceLock for thread safe lazy initialization with the existing get_max_batch_sizes() on frontend creation. ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Description of changes
This PR removes the push_logs_batch_size from sqlite config, and replaces it with max_batch_size. It sets up with OnceLock for thread safe lazy initialization with the existing get_max_batch_sizes() on frontend creation.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?