Skip to content

[CLN] Fix dedup in get_collections_with_new_data. #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jun 27, 2025

Description of changes

We cannot remove this condition, but we can make it match the other one.

Test plan

CI

Documentation Changes

N/A

We cannot remove this condition, but we can make it match the other one.
Copy link
Contributor

This PR updates the deduplication logic in the get_collections_with_new_data method of rust/log/src/grpc_log.rs to sort by both collection_id and first_log_offset before deduplication, matching the logic used elsewhere in the codebase. Only the sort and dedup key are modified; no other logic is changed.

This summary was automatically generated by @propel-code-bot

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv merged commit 51089f2 into main Jun 30, 2025
58 checks passed
rescrv added a commit that referenced this pull request Jul 1, 2025
## Description of changes

We cannot remove this condition, but we can make it match the other one.

## Test plan

CI

## Documentation Changes

N/A
rescrv added a commit that referenced this pull request Jul 1, 2025
## Description of changes

Included PRs in order:

- **[TST]  Test for #4972 (#4983)**
- **[CLN] Fix dedup in get_collections_with_new_data. (#4974)**
- **[ENH] Implement three-phase garbage collection for WAL3 (#4984)**
- **[CLN] Remove err(Display) from wal3. (#4992)**
- **[ENH] Wire up garbage collector to do 3-phase GC. (#4987)**
- **[ENH]  Do not materialize all fragments to delete. (#5004)**

## Test plan

CI through main and then CI on the hotfix branch.

## Documentation Changes

N/A
@rescrv rescrv deleted the rescrv/clean branch August 1, 2025 18:18
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

We cannot remove this condition, but we can make it match the other one.

## Test plan

CI

## Documentation Changes

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants