[ENH] If the dirty log fails with LogContentionDurable, do not fail the operation.

[rescrv]

Description of changes

Both roll_dirty_log and mark_dirty append to the dirty log. At high gc
rates, this can fail, and the operation will fail. We can simply return
Ok(()) for any case where the log is durable.

Test plan

CI

Documentation Changes

N/A

[propel-code-bot]

Handle LogContentionDurable Errors Gracefully in Dirty Log Operations

This PR modifies both the log-service and the wal3 implementation so that operations which would fail due to a LogContentionDurable error when appending to the dirty log now succeed instead, treating this error as a non-fatal, recoverable state. This improves reliability during high garbage collection rates by preventing spurious failures when the log is already in a durable state.

Key Changes:
• In wal3::writer, wrap mark_dirty async to return Ok(()) on Error::LogContentionDurable instead of failing.
• In log-service, update save_dirty_log (reached via roll_dirty_log) to accept Ok or LogContentionDurable as non-errors when appending many dirty markers.
• Remove Display-level error annotation from tracing macro in wal3::manifest for consistency (minor).

Affected Areas:
• rust/wal3/src/writer.rs
• rust/log-service/src/lib.rs
• rust/wal3/src/manifest.rs (tracing instrumentation)

This summary was automatically generated by @propel-code-bot

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)