-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH]: migrate current metering functionality to new metering lib #4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Migrate Metering Functionality to New Metering Library This major PR migrates all existing Rust-side metering (usage tracking/events around collection operations) out of the old chroma-tracing-based design and over to a new centralized 'chroma-metering' library. No new metering features are introduced; rather, the entire metering data pathway, event types, field tracking, and integration points across the frontend and service layers are rewritten to leverage the library's new event contexts, atomic value handling, and event submission patterns. Extensive refactoring is performed across service logic, event construction, and API surfaces, and a reusable library (with macro-accelerated trait-based context/event definitions) is now the single source for all Rust metering primitives, event serialization/deserialization, and async event submission. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
…per/chroma-metering-macros-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…roma-core#4868) ## Description of changes This PR migrates all of the existing metering functionality of Chroma to use the metering library created in chroma-core#4746. It does not introduce any new metering functionality on top of what was present before. ## Test plan - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
This PR uses the `chroma-metering` library introduced in chroma-core#4868 to add execution timing to requests received on the frontend.⚠️ chroma-core#4868 should be merged first. - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
Description of changes
This PR migrates all of the existing metering functionality of Chroma to use the metering library created in #4746. It does not introduce any new metering functionality on top of what was present before.
Test plan
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A