-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ci: fix requirements.txt #4633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: fix requirements.txt #4633
Conversation
This PR updates the FastAPI dependency in requirements.txt, changing it from an exact version pin (==0.115.9) to a minimum version requirement (>=0.115.9). This allows the CI and codebase to accept newer FastAPI versions starting from 0.115.9, easing dependency management. This summary was automatically generated by @propel-code-bot |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@@ -1,5 +1,5 @@ | |||
bcrypt>=4.0.1 | |||
fastapi==0.115.9 | |||
fastapi>=0.115.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BestPractice]
The change from pinned version fastapi==0.115.9
to minimum version fastapi>=0.115.9
could introduce compatibility issues if future FastAPI versions have breaking changes. Consider whether this dependency should remain pinned to ensure consistent behavior across environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is the exact reason why i am proposing relaxing the pinnned versions. chroma is a library code, and any pinned version has a very good chance to conflict with other library codes or application code that might be pinning fastapi
versions.
not putting a bound to major version to stay consistent with the rest of the requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leehanchung - agreed. I think it was intended to be pinned temporarily and never unpinned. We can remove this dep entirely now, since our server is in rust and we no longer use fastapi. cc @jairad26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Look forward to the next release.
Description of changes
relax dependency with
fastapi
.Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?