Skip to content

ci: fix requirements.txt #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

leehanchung
Copy link

Description of changes

relax dependency with fastapi.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor

This PR updates the FastAPI dependency in requirements.txt, changing it from an exact version pin (==0.115.9) to a minimum version requirement (>=0.115.9). This allows the CI and codebase to accept newer FastAPI versions starting from 0.115.9, easing dependency management.

This summary was automatically generated by @propel-code-bot

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@@ -1,5 +1,5 @@
bcrypt>=4.0.1
fastapi==0.115.9
fastapi>=0.115.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BestPractice]

The change from pinned version fastapi==0.115.9 to minimum version fastapi>=0.115.9 could introduce compatibility issues if future FastAPI versions have breaking changes. Consider whether this dependency should remain pinned to ensure consistent behavior across environments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the exact reason why i am proposing relaxing the pinnned versions. chroma is a library code, and any pinned version has a very good chance to conflict with other library codes or application code that might be pinning fastapi versions.

not putting a bound to major version to stay consistent with the rest of the requirements.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leehanchung - agreed. I think it was intended to be pinned temporarily and never unpinned. We can remove this dep entirely now, since our server is in rust and we no longer use fastapi. cc @jairad26

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Look forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants