Skip to content

[BLD] retry kind setup #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

[BLD] retry kind setup #4584

merged 1 commit into from
May 20, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented May 20, 2025 •
edited
Loading

Description of changes

Retry kind setup. DNS appears to occasionally flake: https://github.com/chroma-core/chroma/actions/runs/15145093152/job/42578809842

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the bld-retry-kind-setup branch from a1f4f97 to cffc450 Compare May 20, 2025 20:24
@codetheweb codetheweb marked this pull request as ready for review May 20, 2025 20:26
@codetheweb codetheweb requested a review from HammadB May 20, 2025 20:26
@codetheweb codetheweb enabled auto-merge (squash) May 20, 2025 20:27
@codetheweb codetheweb merged commit 42eb880 into main May 20, 2025
70 checks passed
@codetheweb codetheweb deleted the bld-retry-kind-setup branch May 20, 2025 22:10
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
@codetheweb @Inventrohyder
[BLD] retry kind setup (chroma-core#4584)
fb32143 
## Description of changes

Retry kind setup. DNS appears to occasionally flake:
https://github.com/chroma-core/chroma/actions/runs/15145093152/job/42578809842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetheweb @HammadB