Skip to content

[CLN] Clean up OTel config for better tracing #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

drewkim
Copy link
Contributor

@drewkim drewkim commented May 19, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

drewkim commented May 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@drewkim drewkim marked this pull request as ready for review May 19, 2025 23:38
Copy link
Contributor

propel-code-bot bot commented May 19, 2025

Clean Up and Simplify OTel Tracing Configuration

This PR refactors the OpenTelemetry tracing configuration in rust/tracing/src/init_tracer.rs by simplifying how layers are applied and removing overly complex or redundant filtering logic. The changes include updating service names, removing custom filters from the stdout layer, and adjusting the composition of tracing layers to streamline how tracing is set up across services.

Key Changes:
• Replaced 'hosted-frontend' service entry with 'hosted_frontend' and added 'billing_service'.
• Removed all custom filtering logic from init_stdout_layer (now a simple pretty print).
• Removed explicit global filtering from the OTel tracing init sequence (commented out init_global_filter_layer in init_otel_tracing).
• Refactored layer composition: Layers are now merged using and_then, removing use of multiple EnvFilter/FilterFn applications.
• Simplified layer setup in init_otel_layer and init_stdout_layer.

Affected Areas:
• rust/tracing/src/init_tracer.rs
• Tracing/Observability initialization across all Rust services using OTel

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant