-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Deployment guide updates #2906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 7, 2024 20:25
47c494c
to
7bb380b
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 7, 2024 20:26
7bb380b
to
0a2c01f
Compare
atroyn
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in Vercel. Additionally (possibly as follow-ups):
- let's move thin-client out of the main guides
- let's think about how we are going to separate 'client/server' from the main guide
- let point at the deployment documentation at appropriate sections in the docs
- let's add the perf evals in this section
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 04:50
bf9eeb5
to
0bc6567
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 18:36
0bc6567
to
3a737fd
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 19:02
bb375bc
to
cb5c513
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 19:06
cb5c513
to
e817754
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 20:30
e817754
to
72947cd
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 20:34
72947cd
to
359e8c8
Compare
itaismith
force-pushed
the
itai/aws-guide-update
branch
from
October 9, 2024 20:41
359e8c8
to
5d7d4cb
Compare
atroyn
approved these changes
Oct 9, 2024
send it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Test plan
Followed instructions to verify things are working.
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
This PR