Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Move validation logic to server #2709

Closed
wants to merge 1 commit into from
Closed

[CLN] Move validation logic to server #2709

wants to merge 1 commit into from

Conversation

spikechroma
Copy link

@spikechroma spikechroma commented Aug 22, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Move validation logic for embedding set operations from client to server
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@spikechroma spikechroma changed the title move validation logic to server [CLN] Move validation logic to server Aug 22, 2024
This was referenced Aug 22, 2024
Closed
Closed
Closed
@spikechroma Graphite App
Copy link
Author

spikechroma commented Aug 22, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikechroma and the rest of your teammates on Graphite Graphite

@spikechroma spikechroma marked this pull request as ready for review August 22, 2024 20:46
@spikechroma spikechroma mentioned this pull request Aug 22, 2024
Closed
1 task
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 9bcbf47 to fa4b7bc Compare August 22, 2024 21:53
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from fa4b7bc to 5fa105d Compare August 22, 2024 22:19
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 5fa105d to 7baf48e Compare August 22, 2024 23:14
@spikechroma
Copy link
Author

related issue: #164

@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 7d4c032 to 88a12a9 Compare August 23, 2024 04:04
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 88a12a9 to beb307f Compare August 23, 2024 23:45
@spikechroma spikechroma mentioned this pull request Aug 24, 2024
Open
1 task
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from beb307f to 69c1af2 Compare August 26, 2024 23:13
atroyn
atroyn requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@atroyn atroyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss

chromadb/api/models/CollectionCommon.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/test/test_api.py Outdated Show resolved Hide resolved
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 69c1af2 to 7046b55 Compare August 27, 2024 02:53
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 9511c08 to efb7cf5 Compare August 27, 2024 05:02
HammadB
HammadB reviewed Aug 27, 2024
View reviewed changes
chromadb/test/test_api.py Outdated Show resolved Hide resolved
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch 2 times, most recently from df9c88d to a89ebef Compare September 10, 2024 00:02
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch 3 times, most recently from a8d984a to 06b289a Compare September 10, 2024 18:35
@spikechroma spikechroma mentioned this pull request Sep 10, 2024
Closed
1 task
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch 3 times, most recently from 96c27d1 to 45316d7 Compare September 11, 2024 02:42
spikechroma
spikechroma commented Sep 11, 2024
View reviewed changes
chromadb/api/types.py Outdated Show resolved Hide resolved
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from ced0644 to 6742634 Compare September 11, 2024 22:22
@atroyn atroyn self-assigned this Sep 11, 2024
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from cecf191 to b8a6b94 Compare September 11, 2024 23:13
@spikechroma spikechroma force-pushed the spike/generate_ids_move_validation branch from 0b2b9e1 to ec37c1a Compare September 11, 2024 23:51
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from 5c2bf55 to 75087a8 Compare September 12, 2024 21:10
@atroyn atroyn force-pushed the spike/generate_ids branch 2 times, most recently from 8253eed to 63ae52b Compare September 12, 2024 23:00
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from 75087a8 to 7a4db81 Compare September 12, 2024 23:02
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch 2 times, most recently from 0247ba4 to c2b44b6 Compare September 13, 2024 23:14
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from c2b44b6 to cea408e Compare October 2, 2024 22:04
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from cea408e to 4e27cd5 Compare October 2, 2024 22:45
@atroyn atroyn closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atroyn atroyn atroyn approved these changes

@HammadB HammadB Awaiting requested review from HammadB

Assignees

@atroyn atroyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikechroma @atroyn @HammadB