Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Introduce stream abstraction and enable concurrency test for blockfile #2454

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[ENH] Introduce stream abstraction and enable concurrency test for blockfile #2454

merged 1 commit into from
Jul 16, 2024

Conversation

Ishiihara
Copy link
Contributor

@Ishiihara Ishiihara commented Jul 3, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • The tokio filesystem API will trigger panic if not invoked in the tokio runtime. However, the shuttle concurrency test has its runtime and can not properly run if tokio filesystem APIs are called.
    • To fix the above issue, this PR introduces the stream abstraction to support sync and async local filesystem APIs.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Ishiihara Ishiihara mentioned this pull request Jul 3, 2024
Merged
1 task
@Ishiihara Graphite App
Copy link
Contributor Author

Ishiihara commented Jul 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Ishiihara and the rest of your teammates on Graphite Graphite

@Ishiihara Ishiihara force-pushed the liquan_block_cache_with_eviction branch from b253dcc to ce5123c Compare July 8, 2024 21:03
@Ishiihara Ishiihara mentioned this pull request Jul 9, 2024
Merged
1 task
@Ishiihara Ishiihara force-pushed the liquan_stream_abstraction branch 2 times, most recently from a7f5120 to 38a85c2 Compare July 9, 2024 23:25
@Ishiihara Ishiihara self-assigned this Jul 10, 2024
@Ishiihara Ishiihara marked this pull request as ready for review July 10, 2024 17:06
@Ishiihara Ishiihara changed the title [ENH] Introduce stream abstraction [ENH] Introduce stream abstraction and enable concurrency test for blockfile Jul 10, 2024
@Ishiihara Ishiihara requested review from HammadB and sanketkedia and removed request for HammadB July 11, 2024 15:18
@HammadB HammadB self-requested a review July 12, 2024 03:13
HammadB
HammadB reviewed Jul 12, 2024
View reviewed changes
rust/worker/src/storage/local.rs
@@ -20,15 +21,15 @@ impl LocalStorage {
pub(crate) async fn get(
&self,
key: &str,
) -> Result<Box<dyn AsyncBufRead + Unpin + Send>, String> {
) -> Result<Box<dyn Stream<Item = ByteStreamItem> + Unpin + Send>, String> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this impl still? Can't we just get rid of it and only use SyncLocalStorage?

HammadB
HammadB reviewed Jul 12, 2024
View reviewed changes
rust/worker/src/index/hnsw_provider.rs
@@ -128,44 +132,71 @@ impl HnswIndexProvider {
// Fetch the files from storage and put them in the index storage path
for file in FILES.iter() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you copy the current tracing on main?

@Ishiihara Ishiihara force-pushed the liquan_block_cache_with_eviction branch from ce5123c to 3bcf445 Compare July 16, 2024 06:33
@Ishiihara Ishiihara changed the base branch from liquan_block_cache_with_eviction to main July 16, 2024 07:34
@Ishiihara Ishiihara merged commit 2e5bff4 into main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB left review comments

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees

@Ishiihara Ishiihara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ishiihara @HammadB