Skip to content

Add LTC Bech32 Support #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Conversation

rraina
Copy link

@rraina rraina commented Aug 18, 2020

Resolves #10

All Tests Passing:
image

Please note that I had to update the tests for a couple addresses since they were actually incorrect. They were valid bech32 addresses, but for the wrong network. I re-validated my test updates using this site

@rraina rraina mentioned this pull request Aug 18, 2020
@rraina
Copy link
Author

rraina commented Aug 19, 2020

@christsim -- any feedback on this PR?

@christsim christsim merged commit 17e2468 into christsim:master Aug 20, 2020
@rraina rraina deleted the rr-ltc-bech32-support branch August 20, 2020 13:03
@christsim
Copy link
Owner

Merged into 0.4.7. Please let me know if you have any issues with it.

@rraina
Copy link
Author

rraina commented Aug 20, 2020

Thanks @christsim for merging this in so promptly 🙏 Looking forward to using this!

rraina added a commit to trmlabs/multicoin-address-validator that referenced this pull request Oct 13, 2020
* Added bech32 support for litecoin

* Added dist files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ltc wont validate
2 participants