Skip to content

Commit

Permalink
Address archboard feedback (Azure#27478)
Browse files Browse the repository at this point in the history
* temp changes to add in duplicate method for breaking change rename

* rename Feature -> ArmFeature

* rename Alias to ResourceTypeAlias

* rename ParameterDefinitionsValue to ArmPolicyParameter

* revert Feature rename since the resource suffix pr will fix it

* update tests and api

* align names with Azure.Identity

* update api

* update param name

* remove custom NoWarn

* Update AutoRest C# version to 3.0.0-beta.20220317.3

* address pr comments on related class renames

* fix test references

* remove duplicate api

* suppress Alias in resources

Co-authored-by: azure-sdk <azuresdk@microsoft.com>
  • Loading branch information
m-nash and azure-sdk authored Mar 18, 2022
1 parent 1c63b26 commit d9cc832
Show file tree
Hide file tree
Showing 72 changed files with 1,007 additions and 954 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,22 @@ private ArmEnvironment GetEnvironment(string endpoint)
{
if (string.IsNullOrEmpty(endpoint))
{
return ArmEnvironment.AzureCloud;
return ArmEnvironment.AzurePublicCloud;
}

var baseUri = new Uri(endpoint);

if (baseUri == ArmEnvironment.AzureCloud.BaseUri)
return ArmEnvironment.AzureCloud;
if (baseUri == ArmEnvironment.AzurePublicCloud.Endpoint)
return ArmEnvironment.AzurePublicCloud;

if (baseUri == ArmEnvironment.AzureChinaCloud.BaseUri)
return ArmEnvironment.AzureChinaCloud;
if (baseUri == ArmEnvironment.AzureChina.Endpoint)
return ArmEnvironment.AzureChina;

if (baseUri == ArmEnvironment.AzureGermanCloud.BaseUri)
return ArmEnvironment.AzureGermanCloud;
if (baseUri == ArmEnvironment.AzureGerman.Endpoint)
return ArmEnvironment.AzureGerman;

if (baseUri == ArmEnvironment.AzureUSGovernment.BaseUri)
return ArmEnvironment.AzureUSGovernment;
if (baseUri == ArmEnvironment.AzureGovernment.Endpoint)
return ArmEnvironment.AzureGovernment;

return new ArmEnvironment(new Uri(endpoint), TestEnvironment.ServiceManagementUrl ?? $"{endpoint}/.default");
}
Expand Down
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
All should have PrivateAssets="All" set so they don't become package dependencies
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20220317.1" PrivateAssets="All" />
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20220317.3" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20220111.2" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit d9cc832

Please sign in to comment.