Merged
Conversation
claude bot
pushed a commit
that referenced
this pull request
Dec 14, 2025
…, Duration extension - Fix #3: Simplified ToolMacro execute() wrapper to assign extracted parameters to struct properties and call user's execute() directly, made method mutating - Fix #5: Made ResilientAgent resilience config properties nonisolated to fix actor isolation in chaining initializer - Fix #6: Added Duration.timeInterval extension for TimeInterval conversion - #4: SendableValue encoding verified complete - no changes needed Co-authored-by: Christopher Karani <christopherkarani@users.noreply.github.com>
Merged
claude bot
pushed a commit
that referenced
this pull request
Dec 28, 2025
This commit addresses 7 out of 15 issues identified in the code review: Critical Issues Fixed: - Issue #2: ModelSettings.merged() now validates and throws on invalid merged settings - Issue #3: MCPClient.getAllTools() fixed race condition via task deduplication pattern - Issue #8: MCPResponse init changed from precondition to throwing error for safety High-Priority Issues Fixed: - Issue #4: MCPClient.closeAll() now uses structured concurrency for parallel execution - Issue #10: ResponseTracker now enforces session limits with LRU eviction (default: 1000 sessions) Changes: - ModelSettings.merged() signature changed to throwing (BREAKING CHANGE for callers) - MCPResponse() init now throws instead of using precondition - ResponseTracker adds maxSessions parameter with LRU session eviction - MCPClient uses task deduplication to prevent duplicate cache refreshes - MCPClient.closeAll() executes server closures concurrently Remaining issues (#5, #6, #7, #9, #11-#15) deferred as they require more significant API design changes or are lower priority optimizations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Christopher Karani <christopherkarani@users.noreply.github.com>
christopherkarani
added a commit
that referenced
this pull request
Feb 13, 2026
- Issue #4: Replace convertToSendableValue with SendableValue.fromJSONValue - Issue #5: Extract HiveDeterministicSort utility enum with byName, toolCalls, and strings methods for consistent UTF-8 deterministic sorting - Issue #8: Merge rejectedOutput/cancelledOutput into makeApprovalOutput helper - Issue #9: Promote toJSONObject from fileprivate to internal (module-level) - Issue #12: Add defense-in-depth doc comment for approval re-check - Issue #13: Add defense-in-depth doc comment for compaction validation - Issue #18: Add comment explaining llmInputMessages channel initialization - Issue #19: Add log warning for linear backoff step approximation - Issue #20: Add log warning for custom backoff fallback - Issue #21: Replace String(reflecting:) with String(describing:) in codec ID
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Installing Claude Code GitHub App
This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository.
What is Claude Code?
Claude Code is an AI coding agent that can help with:
How it works
Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment.
Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action.
Important Notes
Security
There's more information in the Claude Code action repo.
After merging this PR, let's try mentioning @claude in a comment on any PR to get started!