Skip to content

iOS 16.4 printing - background graphics support #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

iOS 16.4 printing - background graphics support #294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19dd1f
iOS 16.4 printing - background graphics support
rozekfr May 26, 2023
6550c97
Update RNHTMLtoPDF.m
rozekfr May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ios/RNHTMLtoPDF/RNHTMLtoPDF.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ - (instancetype)init
_paddingLeft = [RCTConvert float:options[@"padding"]];
_paddingRight = [RCTConvert float:options[@"padding"]];
}

if (@available(iOS 16.4, *)) {
if (options[@"backgroundGraphics"]) {
_webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the option should be converted via RCTConvert.

Suggested change
_webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue];
_webView.configuration.preferences.shouldPrintBackgrounds = [RCTConvert BOOL:options[@"backgroundGraphics"]];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, [WKWebView configuration] should only be accessed from the main thread.

Suggested change
_webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue];
dispatch_sync(dispatch_get_main_queue(), ^{
_webView.configuration.preferences.shouldPrintBackgrounds = [RCTConvert BOOL:options[@"backgroundGraphics"]];
});

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for saving my day 🥳

}
}

NSString *path = [[NSBundle mainBundle] bundlePath];
NSURL *baseURL = [NSURL fileURLWithPath:path];
Expand Down