Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom header and footer the same way as in BeautifulHugo. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

excitoon
Copy link

Hi.

I would appreciate if you keep underscores in file names in order to have more or less standard names for custom files.

Kind regards,
Vladimir.

@excitoon
Copy link
Author

Hi, @christianmendoza

Can you please take a look at my patch?

Kind regards,
Vladimir.

@escalate
Copy link

Hello @excitoon

thank you for your PR. I received the ownership for this project and will try to include your code into my fork as quick as possible.

For the moment I don't understand the need of this change. It would be very helpful if you could explain some use cases for this change.

The code looks like that somebody could break the whole layout with the help of footer_custom or header_custom if it used not properly. It is not very safe to use it in my opinion.

Another point is that an implicit documentation inside the files is not very helpful.
It would be better to write all posible configuration options inside the README.md and explain how to and under wich circumstances to use them.

If you like you could create a new PR for the repository at https://github.com/escalate/hugo-split-theme.

oagostinho pushed a commit to oagostinho/hugo-split-theme that referenced this pull request Jan 23, 2019
Remove type="text/css" from style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants