Skip to content

Compare recent file paths using native separators in the test - #2

Merged
christianhelle merged 1 commit into
mainfrom
feature/epic-swanson-1d266c
Sep 19, 2026
Merged

christianhelle merged 1 commit into
mainfrom
feature/epic-swanson-1d266c

Conversation

@christianhelle

Copy link
Copy Markdown
Owner

RecentConnectionsTest.KeepsAnExistingFile failed on Windows.

RecentConnections::sanitize intentionally stores file paths with native separators (\ on Windows), but the test built its expected path from QTemporaryDir::path(), which uses /. The test now compares against QDir::toNativeSeparators(path). This is a no-op on Linux and macOS.

Production code is unchanged.

Verified with pwsh -NoProfile -File build.ps1 on Windows: 194 passed, 27 skipped (server-backed provider tests without SQLQUERY_TEST_* set).

Copilot AI lite review requested due to automatic review settings September 19, 2026 21:30
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: f042e9e5-f479-46da-8c2b-cd1e86c6fe78

📥 Commits

Reviewing files that changed from the base of the PR and between c681451 and 2e088e8.

📒 Files selected for processing (1)
  • tests/test_recentconnections.cpp

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The test now matches platform-native path behavior and has been verified on Windows.

Review effort: Lite
Findings: None

What changed in this PR

Updates the recent-connections test to compare file paths using native separators, fixing Windows failures without changing production code.

Changes:

  • Adds the QDir include.
  • Normalizes the expected path with QDir::toNativeSeparators().
File Description
tests/​test_recentconnections.cpp Makes the existing-file assertion platform-independent.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@christianhelle
christianhelle merged commit af0152a into main Sep 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants