Repository navigation
Compare recent file paths using native separators in the test - #2
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test now matches platform-native path behavior and has been verified on Windows.
Review effort: Lite
Findings: None
What changed in this PR
Updates the recent-connections test to compare file paths using native separators, fixing Windows failures without changing production code.
Changes:
- Adds the
QDirinclude. - Normalizes the expected path with
QDir::toNativeSeparators().
| File | Description |
|---|---|
tests/test_recentconnections.cpp |
Makes the existing-file assertion platform-independent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RecentConnectionsTest.KeepsAnExistingFilefailed on Windows.RecentConnections::sanitizeintentionally stores file paths with native separators (\on Windows), but the test built its expected path fromQTemporaryDir::path(), which uses/. The test now compares againstQDir::toNativeSeparators(path). This is a no-op on Linux and macOS.Production code is unchanged.
Verified with
pwsh -NoProfile -File build.ps1on Windows: 194 passed, 27 skipped (server-backed provider tests withoutSQLQUERY_TEST_*set).