Fix ISO date format handling when dateFormat is defined in settings file

[christianhelle]

This should fix the #599

This pull request includes several changes to improve the handling of date formats and enhance test coverage in the Refitter project. The most important changes include modifying the CodeGeneratorSettings class to support nullable date format strings, updating the GetQueryAttribute method to use the new date format property, and expanding the test suite to cover various scenarios related to date formats and settings.

Enhancements to date format handling:

• src/Refitter.Core/Settings/CodeGeneratorSettings.cs: Modified the DateFormat property to be nullable and added a summary comment.
• src/Refitter.Core/ParameterExtractor.cs: Updated the GetQueryAttribute method to use the new nullable DateFormat property in CodeGeneratorSettings.

Improvements to test coverage:

• src/Refitter.Tests/Examples/UseIsoDateFormatTests.cs: Added multiple test cases to verify the correct generation of code with different date format settings and scenarios.
• src/Refitter.Tests/Examples/UseIsoDateFormatTests.cs: Included AutoFixture.Xunit2 for parameterized tests and adjusted the formatting of the OpenApiSpec constant. [1] [2]

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (170483f) to head (8df0461).
Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   95.03%   98.96%   +3.93%     
==========================================
  Files          54       54              
  Lines        2677     2607      -70     
==========================================
+ Hits         2544     2580      +36     
+ Misses         99        4      -95     
+ Partials       34       23      -11     

Flag	Coverage Δ
unittests	98.96% <100.00%> (+3.93%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Fargekritt]

Making it IsDate and not IsDateOrDateTime will make the format date-time to be ignored. UseIsoDateFormat does currently not work with date-time iirc

[Fargekritt]

      "V1EndUserDialogActivitiesQueriesGet_Activity": {
        "additionalProperties": false,
        "properties": {
          "createdAt": {
            "format": "date-time",
            "nullable": true,
            "type": "string"
          },

Example from our swagger.json
if both are set to IsDate there is no way to configure these properties

[christianhelle]

@maksionkin suggested introducing explicit settings for TimeFormat and DateTimeFormat instead of just having DateFormat. I think it's an okay solution to have 3 separate date/time formatting options

What do you think @Fargekritt ?

[maksionkin]

and by default they should be null (no format)

[christianhelle]

@maksionkin Is it possible to apply a [Query] format to a TimeSpan in Refit? Never tried

[Fargekritt]

Having seperate for all 3 sounds good i think. i feel it could also make the settings bloated with many basicly the same settings? CodeGeneratorSettings makes sense to be verbose imo so one for each makes sense.

but do we want to have to setUseIsoDateFormat UseIsoDateTimeFormat and UseIsoTimeFormat to fully use the Iso format? Should there atleast be a setting all 3 to Iso?

And doesnt this PR implement a breaking change? and should in theory be V2? How strictly are the semver being followed? This change would break my current use usage. but i dont think there is anyone else affected by this change anyways

[christianhelle]

@maksionkin Is it possible to apply a [Query] format to a TimeSpan in Refit? Never tried

Just tried playing with TimeSpan query formatting and I couldn't get it to work so I'm dropping it

[christianhelle]

Having seperate for all 3 sounds good i think. i feel it could also make the settings bloated with many basicly the same settings? CodeGeneratorSettings makes sense to be verbose imo so one for each makes sense.

but do we want to have to setUseIsoDateFormat UseIsoDateTimeFormat and UseIsoTimeFormat to fully use the Iso format? Should there atleast be a setting all 3 to Iso?

@Fargekritt I think the option useIsoDateFormat should apply to both date and date-time format. As it is right now, using useIsoDateFormat will ignore the codeGeneratorSettings.dateFormat setting

[christianhelle]

@Fargekritt @maksionkin As this pull request is already merged in, I started a new one and suggest we move the discussion there