Fixed issue 63: `Webpage shows a 'loading' wheel in tabs even when fu…#66
Open
Faleidel wants to merge 1 commit intochrispsn:masterfrom
Open
Fixed issue 63: `Webpage shows a 'loading' wheel in tabs even when fu…#66Faleidel wants to merge 1 commit intochrispsn:masterfrom
Faleidel wants to merge 1 commit intochrispsn:masterfrom
Conversation
…lly loaded` by changing some contentDocument.write to creating scrip elements and appending them to the document. Fixed opening the code editor making the page scroll vertically because the editor was taking a bit too much space.
Owner
|
Thank you for this! Is it necessary to put the code in |
Owner
|
FYI - I separately committed the display fixes (thank you) as I need to think through the separate file thing. |
Author
|
It doesn't need an other file. I was under the impression that app.js needed to stay as it was to be reused in other context? I think I was just confused... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lly loaded` by changing some contentDocument.write to creating scrip elements and appending them to the document.
Fixed opening the code editor making the page scroll vertically because the editor was taking a bit too much space.