core: tagging an empty note should not create a content item

chrispradd · Aug 14, 2023 · 7ff5f00 · 7ff5f00
1 parent d384aa9
commit 7ff5f00
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/core/__tests__/content.test.js b/packages/core/__tests__/content.test.js
@@ -32,3 +32,15 @@ test("adding a deleted content should not throw", () =>
       })
     ).resolves.toBeUndefined();
   }));
+
+test("tagging an empty note should not create an invalid content item", () =>
+  databaseTest().then(async (db) => {
+    const id = await db.notes.add({ title: "Hello" });
+    const contentId = await db.notes.note(id)._note.contentId;
+    expect(contentId).toBeUndefined();
+    expect(await db.content.all()).toHaveLength(0);
+
+    await db.notes.note(id).tag("tag1");
+
+    expect(await db.content.all()).toHaveLength(0);
+  }));
diff --git a/packages/core/src/collections/notes.js b/packages/core/src/collections/notes.js
@@ -106,7 +106,7 @@ export default class Notes extends Collection {
       if (oldNote) note.dateEdited = Date.now();
     }
 
-    if (noteArg.localOnly !== undefined) {
+    if (note.contentId && noteArg.localOnly !== undefined) {
       await this._db.content.add({
         id: note.contentId,
         localOnly: !!noteArg.localOnly