Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROOF AOSTASK_AND_AOSJOB #565 Pages 1496-1506 #802

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HeroicHitesh
Copy link

@HeroicHitesh HeroicHitesh commented Oct 31, 2020

Fixes #565

The remaining work is already done by @hyperbolic2346 in #798.

Made new commit to complete remaining work.

@github-actions github-actions bot added the Type: Proof Comanche55 and Luminary99 files label Oct 31, 2020
@HeroicHitesh
Copy link
Author

@wopian Please review and tell if any changes are required.

@wopian
Copy link
Collaborator

wopian commented Nov 1, 2020

1485—1495 still needs to be proofed if you're up for doing that too :)

@HeroicHitesh
Copy link
Author

1485—1495 still needs to be proofed if you're up for doing that too :)

Yeah sure @wopian. Just one doubt, do I have to open separate PR from a new branch as this branch name doesn't include those pages or should I make a commit to this branch directly?

@wopian
Copy link
Collaborator

wopian commented Nov 1, 2020

You can do it here or create a new branch. Branch name itself doesn't matter 👍

I'm way behind on PRs for it to be an issue though (allows me to review and apply changes without affecting the contributor whose still proofing a file, since many are new to Git and may not know how to deal with merge conflicts or pulling changes)

@HeroicHitesh
Copy link
Author

I'm way behind on PRs for it to be an issue though

If you want I can help you with reviewing PRs.

@HeroicHitesh
Copy link
Author

@wopian Made the remaining changes, please review and let me know if any change is required.

@wopian
Copy link
Collaborator

wopian commented Nov 2, 2020

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof AOSTASK_AND_AOSJOB
2 participants