Skip to content

Delete hello world #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

Delete hello world #24

merged 1 commit into from
Jun 30, 2018

Conversation

@krispenney
Copy link
Contributor

@krispenney krispenney commented Jun 28, 2018

Removing a few hello_world artifacts!

Delete hello world
d6e69c1 
Missed one
@krispenney krispenney force-pushed the delete-hello-world branch from 99e232d to d6e69c1 Compare June 28, 2018 02:15
@chrisknepper
Copy link
Owner

chrisknepper commented Jun 29, 2018

Thanks for doing this!
I would definitely like to implement some real unit tests and e2e tests for this code. Since running tests are part of the build script, I just need to verify that the builds will still work with these files deleted. If so, I'm happy to merge.

@chrisknepper chrisknepper merged commit 4e7638a into chrisknepper:master Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krispenney @chrisknepper